Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds validation for max dosage in PRN prescription #8324 #8378

Merged

Conversation

Nithin9585
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • [] Request for Peer Reviews
  • [] Completion of QA

Screenshot 2024-08-21 000732

@Nithin9585 Nithin9585 requested a review from a team as a code owner August 20, 2024 19:25
Copy link

vercel bot commented Aug 20, 2024

@Nithin9585 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c336e7e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c5c3fb460eef00087adb48
😎 Deploy Preview https://deploy-preview-8378--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nithin9585 good work, just i18n the error strings

src/Components/Medicine/validators.ts Outdated Show resolved Hide resolved
Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 88b75ef
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66d586593fa0b400086aff6a
😎 Deploy Preview https://deploy-preview-8378--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish bodhish removed the request for review from khavinshankar September 2, 2024 09:48
@bodhish bodhish dismissed khavinshankar’s stale review September 2, 2024 09:49

Removing to merge the PR

@bodhish bodhish merged commit 6245493 into ohcnetwork:develop Sep 2, 2024
27 checks passed
Copy link

github-actions bot commented Sep 2, 2024

@Nithin9585 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@Nithin9585 Nithin9585 deleted the issues/8324/add-max-dosage-validation branch September 2, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for max dosage in PRN prescription
6 participants