Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive print in prescription module #8330

Conversation

kushalbhana
Copy link
Contributor

Enhancement to the prescrition print module

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@kushalbhana kushalbhana requested a review from a team as a code owner August 15, 2024 11:04
Copy link

vercel bot commented Aug 15, 2024

@kushalbhana is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4cc489a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66bde0de5d821b0007449e78
😎 Deploy Preview https://deploy-preview-8330--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushalbhana

  1. Wrong issue is linked to the PR
  2. It is recommended that the issue is assigned to you before working on it. Someone else is already assigned to it.
  3. Not the right way to solve the problem as per the solution mentioned in Support for zooming in and out for PrintPreview component #8323.
  4. Hardcoding arbitrary pixel values is not allowed as it wouldn't align with different screen/browser zoom settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants