Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve visual feedback when filters are applied in CNS and Live Feed page #8156

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Improve visual feedback when filters are applied in CNS and Live Feed page #8156

merged 4 commits into from
Jul 17, 2024
+19 −40

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 16, 2024 •
edited
Loading

Proposed Changes

image image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 16, 2024 06:03
@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 9:08am

@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4fb763b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/669789fb6d3ab70008ff29e6
😎 Deploy Preview https://deploy-preview-8156--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jul 16, 2024 •
edited
Loading

Passing run #2879 ↗︎

0 126 0 0 Flakiness 0

Details:

Improve visual feedback when filters are applied in CNS and Live Feed page
Project: CARE Commit: 4fb763b5c2
Status: Passed Duration: 02:57 💡
Started: Jul 17, 2024 9:13 AM Ended: Jul 17, 2024 9:16 AM

Review all test suite changes for PR #8156 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jul 17, 2024 •
edited by rithviknishad
Loading

image

  • when the location filters are active, the button is not shown active by turning primary colour
  • sort-by shouldn't be considered for this button primary colour behavior

@nihal467
Copy link
Member

@rithviknishad

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a990d8d into develop Jul 17, 2024
62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/7600-live-feed-and-cns-settings-and-filter branch July 17, 2024 11:23
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change the "Setting and filter" button behavior in CNS and Live feed page
3 participants
@rithviknishad @nihal467 @khavinshankar