Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of gray color shade with secondary (alias of gray) for consistency and maintainability #8138

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 11, 2024

This PR replaces all direct usages of the gray color shade in the codebase with the secondary color shade. The secondary color is defined in the tailwind.config.js file to point to the same gray shade values.

Reason for the Change:

To maintain consistency and improve code maintainability, we have introduced secondary as an alias for the gray color shade. By referencing the color as secondary, we can easily update the color scheme in the future by modifying the secondary color definition without changing individual instances across the codebase.

This approach ensures a single source of truth for the secondary color and simplifies future updates to the color palette.

Changes Made:

  • Replaced all instances of the gray color shade with the secondary color shade in the project.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 8:47am

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f5401c9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/668f9c38943e6100089471e8
😎 Deploy Preview https://deploy-preview-8138--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jul 11, 2024

Passing run #2848 ↗︎

0 126 0 0 Flakiness 0

Details:

Replace usages of gray color shade with secondary (alias of gray) for consistenc...
Project: CARE Commit: f5401c9f07
Status: Passed Duration: 03:15 💡
Started: Jul 11, 2024 8:52 AM Ended: Jul 11, 2024 8:55 AM

Review all test suite changes for PR #8138 ↗︎

@nihal467
Copy link
Member

Gave it a over-all look, LGTM

@khavinshankar khavinshankar merged commit 465f8e0 into develop Jul 16, 2024
66 of 68 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/chore/secondary-color branch July 16, 2024 12:45
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants