Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone number field: Adds helper icon to improve how supported phone number types are shown #8126

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 8, 2024 13:37
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 4:12am

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1e4aeff
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/668e0a0841289900080589ef
😎 Deploy Preview https://deploy-preview-8126--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jul 8, 2024

Passing run #2837 ↗︎

0 126 0 0 Flakiness 0

Details:

Phone number field: Adds helper icon to improve how supported phone number types...
Project: CARE Commit: 1e4aefff22
Status: Passed Duration: 03:07 💡
Started: Jul 10, 2024 4:16 AM Ended: Jul 10, 2024 4:19 AM

Review all test suite changes for PR #8126 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

@rithviknishad
image

can we use the above screenshot icon for this purpose, to keep design consistency

@rithviknishad
Copy link
Member Author

I've instead updated the icon in the user create page to be question mark and ensured all other usages are correct.

The question mark icon is more appropriate for "need help".

@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

@rithviknishad
image

the tooltip is clipping out

@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

LGTM

src/Utils/utils.ts Outdated Show resolved Hide resolved
@khavinshankar khavinshankar added the question Further information is requested label Jul 9, 2024
@rithviknishad rithviknishad removed the question Further information is requested label Jul 11, 2024
@khavinshankar khavinshankar merged commit 9ad2780 into develop Jul 11, 2024
61 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/8051 branch July 11, 2024 07:12
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile/Landline Icons are not responding
3 participants