Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows encounter duration in discharge confirmation dialog #8124

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 8, 2024

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:36am

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6f2e320
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/668d04887d9e110008c6f456
😎 Deploy Preview https://deploy-preview-8124--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jul 8, 2024

Passing run #2834 ↗︎

0 126 0 0 Flakiness 0

Details:

Shows encounter duration in discharge confirmation dialog
Project: CARE Commit: 6f2e32078d
Status: Passed Duration: 03:09 💡
Started: Jul 9, 2024 9:40 AM Ended: Jul 9, 2024 9:43 AM

Review all test suite changes for PR #8124 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

image
image

@rithviknishad the IP no of patients are shown as 24 days and in the discharge pop-up it is shown as 25 days, how are we calculating the no of days, is it based on 24 hours clock from the date of admission or is it per night, we need to clarify it with @aparnacoronasafe and modify the PR based on the logic finalised . My suggestion its better to keep logic based on how rooms days are calculated in hospital as we are moving towards billing and schedule

@rithviknishad
Copy link
Member Author

@nihal467

As discussed with @aparnacoronasafe , we've decided to show the n'th day (i.e. the logic in the discharge popup is correct and the IP Days number needs to be incremented by 1)

i.e.:
For first 24 hours: days would be 1
For 24-48th hour: days would be 2
and so on.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit ff70e5f into develop Jul 11, 2024
64 of 65 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/8121 branch July 11, 2024 06:50
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing duration of encounter in discharge popup
3 participants