-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added consent indicators and filters #8003
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #2880 ↗︎
Details:
Review all test suite changes for PR #8003 ↗︎ |
@skks1212 The message on patient list "16 patients admitted without consent" may be edited to say "16 patients admitted missing consent records" |
similar, user apply any advance filter, in the patient tab, it should filter the missing patient consent banner based on that |
@nihal467, are you sure the filters apart from facility filters should change the number shown in the alerts? I believe it is to show patients in that facility (or everywhere) that have no consents regardless of filters. @aparnacoronasafe can you confirm? |
The experience is better when the number on alert responds to all filters. If user applies a filter with list showing on 2 results but alert on top says "10 records with no consent record" doesn't look very convincing. Is there challenge to make it respond to all filters? You are correct in saying that the need to be able to filter based on facility is not valuable in this case. |
@aparnacoronasafe no challenge, just had a doubt. Made the changes |
…consent-filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skks1212 seems multiple cypress tests are failing, please fix those
@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Dependent on ohcnetwork/care#2255
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Screenshots
Merge Checklist