Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and re-lock without legacy peer deps #7785

Merged
merged 6 commits into from
May 15, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented May 9, 2024

Proposed Changes

  • update dependencies upto latest minor/patch versions
  • we no longer have to use legacy peer deps for npm
  • auto-install-peers is a pnpm flag which is enabled by default

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner May 9, 2024 17:53
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 8:12pm

Copy link

netlify bot commented May 9, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 02b6449
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6643c57bc659ff000792013e
😎 Deploy Preview https://deploy-preview-7785--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label May 9, 2024
@sainak sainak removed the Deploy-Failed Deplyment is not showing preview label May 9, 2024
Copy link

cypress bot commented May 9, 2024

Passing run #2521 ↗︎

0 123 0 0 Flakiness 0

Details:

Update dependencies and re-lock without legacy peer deps
Project: CARE Commit: 02b6449f18
Status: Passed Duration: 03:28 💡
Started: May 14, 2024 8:20 PM Ended: May 14, 2024 8:24 PM

Review all test suite changes for PR #7785 ↗︎

@sainak sainak changed the title avoid using legacy peer deps for npm dependencies Update dependencies re-lock without legacy peer deps May 9, 2024
@ohcnetwork ohcnetwork deleted a comment from netlify bot May 9, 2024
@sainak sainak changed the title Update dependencies re-lock without legacy peer deps Update dependencies and re-lock without legacy peer deps May 9, 2024
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 14, 2024
@nihal467
Copy link
Member

@sainak clear the merge conflict

@sainak sainak removed the merge conflict pull requests with merge conflict label May 14, 2024
@nihal467
Copy link
Member

LGTM as build is completed

@khavinshankar khavinshankar merged commit 0d83e5f into develop May 15, 2024
62 checks passed
@khavinshankar khavinshankar deleted the sainak/cleanup-npmrc branch May 15, 2024 01:27
Copy link

@sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants