Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added facility hubs #7772

Merged
merged 12 commits into from
Sep 24, 2024
Merged

Added facility hubs #7772

merged 12 commits into from
Sep 24, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented May 8, 2024

Proposed Changes

image

image

backend : ohcnetwork/care#2135
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@shivankacker shivankacker requested a review from a team as a code owner May 8, 2024 00:50
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 6:15pm

Copy link

netlify bot commented May 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 138169e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c83faa1eb76e000874fca1
😎 Deploy Preview https://deploy-preview-7772--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 8, 2024

CARE    Run #3343

Run Properties:  status check passed Passed #3343  •  git commit a956703f1e: Added facility hubs
Project CARE
Branch Review facility-hubs
Run status status check passed Passed #3343
Run duration 02m 59s
Commit git commit a956703f1e: Added facility hubs
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 128
View all changes introduced in this branch ↗︎

src/Components/Facility/FacilityCreate.tsx Outdated Show resolved Hide resolved
src/Components/Facility/FacilityCreate.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

@skks1212
image

  • currently, it is a click and select dropdown, change it the component, where users can type and select from the dropdown the respective facility
  • currently, it is not reflected anywhere in the facility details page, we should be reflecting the data somewhere in the details page : take an opinion from @aparnacoronasafe for the UI approval

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 22, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 28, 2024
@aparnacoronasafe
Copy link
Member

Please go ahead @shivankacker

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

@shivankacker

image

  • the component is not properly mobile responsive, users are not able to see the input characters in the mobile view
  • add a proper description for the issue, what are the options we are adding, currently i can view only regular and Tele ICU , is that the only option were expected to be added ? add more description on the issue as well as in the PR for review purpose

image

@skks1212 image

  • currently, it is a click and select dropdown, change it the component, where users can type and select from the dropdown the respective facility
  • currently, it is not reflected anywhere in the facility details page, we should be reflecting the data somewhere in the details page : take an opinion from @aparnacoronasafe for the UI approval
  • As mentioned in the Previous comment, we are not at all showing anywhere in the dashboard below things:
  • how many spokes are linked to a hub facility
  • which all facility are hub facility , add a option to mark a facility as hub or spoke, so later on we can filter hub and spoke facility in future
  • we need a location in the facility details page, where we show these details , can you check with @aparnacoronasafe once on the above comments

image

  • Assuming that Dummy Facility A is the hub for Dummy Facility B, can you confirm that if Dummy Facility C can be the hub for Dummy Facility A, given that A is already a hub for B and therefore cannot be a spoke under Facility C?

@nihal467 nihal467 added question Further information is requested test failed and removed needs testing labels Sep 2, 2024
@shivankacker
Copy link
Member Author

@nihal467 I have fixed the responsiveness issue and displayed the spoke relationship on the facility home page after consulting Aparna.
She says that a spoke can be a hub to other spokes.

@shivankacker shivankacker added needs testing and removed question Further information is requested test failed labels Sep 2, 2024
@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

LGTM

@nihal467 nihal467 added tested reviewed reviewed by a core member and removed needs testing needs review labels Sep 2, 2024
Copy link

github-actions bot commented Sep 3, 2024

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 3, 2024
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 13, 2024
@bodhish
Copy link
Member

bodhish commented Sep 19, 2024

@nihal467 @shivankacker
Whats pending here?

@shivankacker
Copy link
Member Author

@bodhish Waiting for Backend

@khavinshankar khavinshankar merged commit 7878cd6 into develop Sep 24, 2024
25 checks passed
@khavinshankar khavinshankar deleted the facility-hubs branch September 24, 2024 15:27
Copy link

@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new field on facility to link a spoke facility to hub facility
7 participants