Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Facility link and unlink button for non-admin users #7738

Merged
merged 12 commits into from
Jun 14, 2024

Conversation

Pranshu1902
Copy link
Contributor

Proposed Changes

Hide Clear Home Facility button:
image

Give Error notification for link and unlink buttons
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner April 29, 2024 15:02
Copy link

vercel bot commented Apr 29, 2024

@Pranshu1902 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4f30830
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66558bb62816c00008469066
😎 Deploy Preview https://deploy-preview-7738--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 30, 2024
@Pranshu1902 Pranshu1902 removed the merge conflict pull requests with merge conflict label Apr 30, 2024
@nihal467
Copy link
Member

nihal467 commented May 7, 2024

@Pranshu1902

image

above is the current stage screenshot

image

above is the PR deployment

  • the PR is not showing the home facility page, can you check into this issue and reverify the code change you made while clearing the merge conflict

@Pranshu1902
Copy link
Contributor Author

@nihal467 resolved the conflicts
updated view:
image

@nihal467
Copy link
Member

nihal467 commented May 8, 2024

@Pranshu1902
image

as per the issue, the button was suggested to be hidden, as non-admin users have no privilege to use it

Copy link

github-actions bot commented May 8, 2024

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 8, 2024
@Pranshu1902
Copy link
Contributor Author

@nihal467 Updated view:
image

@Pranshu1902 Pranshu1902 added needs testing and removed changes required merge conflict pull requests with merge conflict labels May 8, 2024
@github-actions github-actions bot added the stale label May 25, 2024
@Pranshu1902
Copy link
Contributor Author

@nihal467 done
image

@nihal467
Copy link
Member

@Pranshu1902
image

  • admin are not able to see the unlink or link button, do recheck your PR and do basic functionality check before marking it for review

@Pranshu1902
Copy link
Contributor Author

@nihal467 done

Admin View:
image

Nurse View:
image

Nurse View for their profile:
image

@nihal467
Copy link
Member

@Pranshu1902

image

nurse is not able to clear his own home facility access

@Pranshu1902
Copy link
Contributor Author

@nihal467 the backend is rejecting the request for nurse user type.

Raised a backend PR for that: #2206

Screenshot from 2024-05-29 13-22-05

@nihal467
Copy link
Member

nihal467 commented Jun 4, 2024

LGTM

@Pranshu1902
Copy link
Contributor Author

@nihal467 the backend PR has been merged

@khavinshankar khavinshankar merged commit 655202d into ohcnetwork:develop Jun 14, 2024
28 of 30 checks passed
Copy link

@Pranshu1902 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor user privileges in linked facility functionality
3 participants