Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a settings variable to allow configurable time periods for notification deletion #2547

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

arilloid
Copy link
Contributor

Proposed Changes

  • Added NOTIFICATION_RETENTION_DAYS variable that defaults to 30 in the config/settings/base.py under "Push Notifications":

image

  • Modified the delete_old_notifications() to use the settings variable instead of the hardcoded time period

  • Modified the test_delete_old_notifications() to use the settings variable instead of the hardcoded time period

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@arilloid arilloid requested a review from a team as a code owner October 18, 2024 21:17
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.00%. Comparing base (00cd5f9) to head (44c6912).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2547   +/-   ##
========================================
  Coverage    70.00%   70.00%           
========================================
  Files          198      198           
  Lines        11660    11662    +2     
  Branches      1604     1604           
========================================
+ Hits          8162     8164    +2     
  Misses        3107     3107           
  Partials       391      391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 8d5e701 into ohcnetwork:develop Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update delete_old_notifications task to allow configurable time period with default of 30 days
4 participants