added check for email provider check before sending reset password email #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshhari
requested changes
Oct 16, 2024
care/users/tests/test_auth.py
Outdated
|
|
||
| @override_settings( | ||
| IS_PRODUCTION=True, | ||
| EMAIL_HOST="smtp.gmail.com", |
There was a problem hiding this comment.
use a dummy host not something that could actually work.
| EMAIL_HOST_PASSWORD="your-app-password", | ||
| ) | ||
| def test_forgot_password_with_email_configration(self): | ||
| response = self.client.post( |
There was a problem hiding this comment.
We should mock the bits that actually send the email and confirm that the email has been sent.
|
@vigneshhari made the updates , Please take a look |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2544 +/- ##
========================================
Coverage 70.00% 70.00%
========================================
Files 198 198
Lines 11660 11662 +2
Branches 1604 1605 +1
========================================
+ Hits 8162 8164 +2
Misses 3107 3107
Partials 391 391 ☔ View full report in Codecov by Sentry. |
sainak
approved these changes
Oct 21, 2024
|
Tests that check if the email was sent were still not added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins