Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New RBAC Implementation #2515

Merged
merged 13 commits into from
Oct 30, 2024
Merged

New RBAC Implementation #2515

merged 13 commits into from
Oct 30, 2024

Conversation

vigneshhari
Copy link
Member

This PR includes the new RBAC system.
This PR will not be a complete rewrite of the current system. This PR will only introduce the new architecture, In time we will move all of the logic from the current implementation to the new architecture.

@vigneshhari vigneshhari requested a review from a team as a code owner October 1, 2024 16:04
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 20.85308% with 167 lines in your changes missing coverage. Please review.

Project coverage is 69.26%. Comparing base (fa80b2c) to head (62e68dd).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rity/management/commands/sync_permissions_roles.py 0.00% 46 Missing ⚠️
care/security/authorization/base.py 0.00% 40 Missing ⚠️
care/security/permissions/base.py 0.00% 39 Missing ⚠️
care/security/roles/role.py 0.00% 23 Missing ⚠️
care/security/authorization/facility.py 0.00% 13 Missing ⚠️
care/security/permissions/facility.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2515      +/-   ##
===========================================
- Coverage    70.13%   69.26%   -0.88%     
===========================================
  Files          200      211      +11     
  Lines        11717    11928     +211     
  Branches      1187     1208      +21     
===========================================
+ Hits          8218     8262      +44     
- Misses        3123     3290     +167     
  Partials       376      376              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari marked this pull request as draft October 1, 2024 19:52
@vigneshhari vigneshhari marked this pull request as ready for review October 17, 2024 08:48
care/security/models/role.py Outdated Show resolved Hide resolved
care/security/apps.py Outdated Show resolved Hide resolved
care/security/permissions/permissions.py Outdated Show resolved Hide resolved
@vigneshhari vigneshhari merged commit 67c63d9 into develop Oct 30, 2024
5 of 7 checks passed
@vigneshhari vigneshhari deleted the vigneshhari/rbac branch October 30, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants