Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up asset classes #2494

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

DraKen0009
Copy link
Contributor

Proposed Changes

  • Updated assert classes to improve option handling

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Linting Complete

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

@DraKen0009 DraKen0009 requested a review from a team as a code owner September 24, 2024 11:42
@sainak sainak added the blocked label Sep 24, 2024
@sainak
Copy link
Member

sainak commented Sep 24, 2024

blocking for

# Conflicts:
#	care/facility/api/viewsets/asset.py
#	care/utils/assetintegration/base.py
@vigneshhari vigneshhari changed the title Clean up asser classes Clean up asset classes Sep 25, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 60.46512% with 17 lines in your changes missing coverage. Please review.

Project coverage is 69.37%. Comparing base (8d5e701) to head (f75908a).

Files with missing lines Patch % Lines
care/utils/assetintegration/onvif.py 20.00% 8 Missing ⚠️
care/utils/assetintegration/hl7monitor.py 40.00% 3 Missing ⚠️
care/utils/assetintegration/ventilator.py 40.00% 3 Missing ⚠️
care/utils/assetintegration/base.py 90.00% 2 Missing ⚠️
care/facility/api/viewsets/asset.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2494      +/-   ##
===========================================
+ Coverage    69.20%   69.37%   +0.17%     
===========================================
  Files          211      212       +1     
  Lines        11942    11961      +19     
  Branches      1208     1208              
===========================================
+ Hits          8264     8298      +34     
+ Misses        3302     3287      -15     
  Partials       376      376              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DraKen0009
Copy link
Contributor Author

@sainak made the changes. Please check

care/utils/assetintegration/base.py Outdated Show resolved Hide resolved
care/utils/assetintegration/base.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup the constructor of asset classes
4 participants