-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up asset classes #2494
Open
DraKen0009
wants to merge
16
commits into
ohcnetwork:develop
Choose a base branch
from
DraKen0009:improving-asset-classes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clean up asset classes #2494
DraKen0009
wants to merge
16
commits into
ohcnetwork:develop
from
DraKen0009:improving-asset-classes
+227
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocking for |
# Conflicts: # care/facility/api/viewsets/asset.py # care/utils/assetintegration/base.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2494 +/- ##
===========================================
+ Coverage 69.20% 69.37% +0.17%
===========================================
Files 211 212 +1
Lines 11942 11961 +19
Branches 1208 1208
===========================================
+ Hits 8264 8298 +34
+ Misses 3302 3287 -15
Partials 376 376 ☔ View full report in Codecov by Sentry. |
sainak
reviewed
Nov 4, 2024
@sainak made the changes. Please check |
sainak
reviewed
Nov 4, 2024
sainak
approved these changes
Nov 4, 2024
rithviknishad
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Associated Issue
Architecture changes
Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins