resolved issue #2383 #2452
Closed
resolved issue #2383 #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anroopak
requested changes
Sep 17, 2024
| if "medicine" in attrs: | ||
| attrs["medicine"] = get_object_or_404( | ||
| MedibaseMedicine, external_id=attrs["medicine"] | ||
| def validate(self, attrs): |
There was a problem hiding this comment.
Please add valid test cases.
config/authentication.py
Outdated
There was a problem hiding this comment.
Changes in this file is not related to the mentioned issue. Please isolate this to a seperate PR.
|
hey @Dishaswamy this prs has unrelated changes to files and the indentation is also incorrect, |
|
You should start working on a Pull request only when you are assigned the issue. finish up #2450 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #2383
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins