Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flags #2429

Merged
merged 20 commits into from
Sep 19, 2024
Merged

Conversation

vigneshhari
Copy link
Member

This implementation adds the concept of a feature flag and how it can be used in API's

@vigneshhari vigneshhari requested a review from a team as a code owner September 6, 2024 12:57
@vigneshhari vigneshhari marked this pull request as draft September 6, 2024 13:02
@sainak sainak self-assigned this Sep 6, 2024
@shivankacker
Copy link
Member

@vigneshhari this is under progress right? I would like to go ahead with the frontend implementation for this. I am imagining there will be an API exposed that returns whether the particular user is allowed to use a feature or not, which we can use in the frontend to enable/disable features.

@vigneshhari
Copy link
Member Author

@sainak is taking over this MR

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 94.30380% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (a06913e) to head (89952e2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
care/utils/registries/feature_flag.py 91.48% 4 Missing ⚠️
care/facility/admin.py 90.00% 0 Missing and 1 partial ⚠️
care/facility/models/facility_flag.py 95.65% 1 Missing ⚠️
care/users/admin.py 91.66% 0 Missing and 1 partial ⚠️
care/users/models.py 95.83% 1 Missing ⚠️
care/utils/models/base.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2429      +/-   ##
===========================================
+ Coverage    64.57%   64.91%   +0.33%     
===========================================
  Files          240      242       +2     
  Lines        13646    13801     +155     
  Branches      1950     1975      +25     
===========================================
+ Hits          8812     8959     +147     
- Misses        4460     4466       +6     
- Partials       374      376       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sainak sainak marked this pull request as ready for review September 17, 2024 10:30
@sainak sainak changed the title Added Facility Flag Implementation Add feature flags Sep 19, 2024
@vigneshhari vigneshhari merged commit 2bb7357 into develop Sep 19, 2024
10 checks passed
@vigneshhari vigneshhari deleted the vigneshhari/feature_flag_implementation branch September 19, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants