Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch investigation default from dict to list and remove deprecated prescriptions #2410

Merged
merged 10 commits into from
Sep 21, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 29, 2024

Proposed Changes

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.90%. Comparing base (2788679) to head (17c971a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2410      +/-   ##
===========================================
- Coverage    64.91%   64.90%   -0.01%     
===========================================
  Files          242      242              
  Lines        13811    13809       -2     
  Branches      1906     1906              
===========================================
- Hits          8965     8963       -2     
  Misses        4468     4468              
  Partials       378      378              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

@sainak @vigneshhari docker compose exec backend bash -c "python manage.py populate_investigations" command is not working in docker app windows

@rithviknishad
Copy link
Member Author

@nihal467 could you share more details on what the error is? Unable to replicate.

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

LGTM

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024

@nihal467 could you share more details on what the error is? Unable to replicate.

the PR is working well, it's just the investigation loading command for docker is not working, but loaded them using some alternative way aakash suggested and the PR is good to be merged

@rithviknishad rithviknishad assigned anroopak and unassigned anroopak Sep 20, 2024
@rithviknishad rithviknishad self-assigned this Sep 21, 2024
@rithviknishad rithviknishad merged commit 8513421 into develop Sep 21, 2024
10 checks passed
@rithviknishad rithviknishad deleted the rithviknishad/fix/investigations-default branch September 21, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: s.map is not a function in InvestigationBuilder component
5 participants