Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCX Plug #2399

Merged
merged 13 commits into from
Sep 23, 2024
Merged

HCX Plug #2399

merged 13 commits into from
Sep 23, 2024

Conversation

khavinshankar
Copy link
Member

Seperates HCX into a plug

@khavinshankar khavinshankar requested a review from a team as a code owner August 26, 2024 05:37
@khavinshankar khavinshankar mentioned this pull request Aug 26, 2024
6 tasks
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 65.62%. Comparing base (c7637ea) to head (7227ba4).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...e/facility/management/commands/load_redis_index.py 0.00% 13 Missing ⚠️
care/facility/tasks/redis_index.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2399      +/-   ##
===========================================
+ Coverage    65.50%   65.62%   +0.11%     
===========================================
  Files          243      222      -21     
  Lines        14070    13319     -751     
  Branches      1952     1882      -70     
===========================================
- Hits          9217     8741     -476     
+ Misses        4465     4190     -275     
  Partials       388      388              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -181,7 +179,6 @@ def get_discharge_summary_data(consultation: PatientConsultation):
return {
"patient": consultation.patient,
"samples": samples,
"hcx": hcx,
Copy link
Member

@sainak sainak Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should think of a way to allow apps to expose discharge summary template sections and data

cc: @vigneshhari

Copy link
Contributor

@anroopak anroopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

care/facility/api/serializers/patient.py Show resolved Hide resolved
@sainak sainak merged commit 97e715d into develop Sep 23, 2024
6 of 8 checks passed
@sainak sainak deleted the hcx-plug branch September 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants