-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JSON schema validations of Daily Round fields #2386
Update JSON schema validations of Daily Round fields #2386
Conversation
3598c9a
to
43ac3b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2386 +/- ##
===========================================
+ Coverage 64.86% 64.91% +0.04%
===========================================
Files 242 242
Lines 13804 13811 +7
Branches 1904 1906 +2
===========================================
+ Hits 8954 8965 +11
+ Misses 4472 4468 -4
Partials 378 378 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Aakash Singh <[email protected]>
@anroopak can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, please confirm about if it is a typo or not before merging. Will approve after the confirmation.
Custom migrations may cause the release to stall if the table is huge. So need confirmation that it is not so huge.
…acheostomy_tube_change`
Note
PR contains 2 custom migrations to sanitize daily rounds JSON fields
Proposed Changes
name
with value:<empty string>
to"Unknown"
{}
toNone
to simplify validations.Associated Issue
Custom Migrations 1: Sanitize I/O Balance Fields
Migration to sanitize daily rounds I/O balance JSON fields.
Before Migration
After Migration
Reverse Migration
Custom Migrations 2: Sanitize
bp
fieldMigration to set
bp
field toNone
for{}
(empty objects)Before Migration
After Migration
Reverse Migration
Merge Checklist