Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user profile pictures #2253

Merged
merged 26 commits into from
Sep 23, 2024
Merged

Conversation

UdaySagar-Git
Copy link
Contributor

@UdaySagar-Git UdaySagar-Git commented Jun 7, 2024

Proposed Changes

  • A new bucket for storing profile images of users
  • API endpoints to upload/update profile picture of user

Frontend pr : ohcnetwork/care_fe#7995

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

config/settings/base.py Outdated Show resolved Hide resolved
@rithviknishad rithviknishad requested a review from sainak July 9, 2024 10:10
@UdaySagar-Git UdaySagar-Git requested a review from sainak July 9, 2024 10:56
@nihal467
Copy link
Member

nihal467 commented Aug 7, 2024

@UdaySagar-Git can you fix the test and lint failure

@UdaySagar-Git
Copy link
Contributor Author

@nihal467 done

@rithviknishad
Copy link
Member

@sainak Could you review this?

@nihal467
Copy link
Member

@UdaySagar-Git the lint is failing and test is failing can you fix it , so we can review the PR

CC: @sainak @rithviknishad @khavinshankar can anyone of you look into the issue as well

@sainak sainak changed the title New profile picture feature Add user profile pictures Sep 19, 2024
@gigincg
Copy link
Member

gigincg commented Sep 21, 2024

Assigning to @sainak to clear issues and close.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 82.41758% with 16 lines in your changes missing coverage. Please review.

Project coverage is 65.49%. Comparing base (12afd7a) to head (8dd0f6a).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
care/utils/file_uploads/cover_image.py 70.00% 7 Missing and 2 partials ⚠️
care/users/api/viewsets/users.py 86.66% 2 Missing and 2 partials ⚠️
care/users/models.py 60.00% 1 Missing and 1 partial ⚠️
care/facility/api/viewsets/facility.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2253      +/-   ##
===========================================
+ Coverage    65.38%   65.49%   +0.10%     
===========================================
  Files          242      243       +1     
  Lines        13976    14054      +78     
  Branches      1937     1949      +12     
===========================================
+ Hits          9138     9204      +66     
- Misses        4455     4464       +9     
- Partials       383      386       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit e6a55d7 into ohcnetwork:develop Sep 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants