Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICD11: gracefully return None if issues with redis #2231

Merged

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • ICD11: gracefully return None if issues with redis

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2024

LGTM tested through tunnel

@vigneshhari
Copy link
Member

Keep in mind that this is not just redis exceptions, this is gracefully returning on all exceptions, maybe create a ticket to handle it better in the future.

@vigneshhari vigneshhari merged commit 6b2e808 into develop Jun 5, 2024
5 checks passed
@vigneshhari vigneshhari deleted the rithviknishad/fix/icd11-graceful-if-redis-errors branch June 5, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants