Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symptoms table #2186

Merged
merged 27 commits into from
May 28, 2024
Merged

Symptoms table #2186

merged 27 commits into from
May 28, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented May 21, 2024 •
edited by rithviknishad
Loading

Proposed Changes

  • convert symptoms filed to a separate table
  • migrate existing symptoms to the new table
  • Deprecate old symptom fields

Associated Issue

Architecture changes

  • new symptoms table

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

hrit2773 and others added 18 commits May 21, 2024 14:15
@sainak sainak requested a review from a team as a code owner May 21, 2024 08:49
@sainak sainak mentioned this pull request May 21, 2024
Closed
@sainak sainak changed the title consultation depth backend Symptoms table May 21, 2024
rithviknishad
rithviknishad requested changes May 21, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to DELETE to set as entered in error. Stays in in-progress or completed.

image image

This was referenced May 21, 2024
Merged
Merged
@sainak sainak requested a review from rithviknishad May 21, 2024 14:02
@nihal467
Copy link
Member

LGTM tested through Tunnel

@nihal467 nihal467 added the P1 High priority; urgent label May 28, 2024
@vigneshhari vigneshhari merged commit de22042 into develop May 28, 2024
9 checks passed
@vigneshhari vigneshhari deleted the sainak/feat/symptoms-table branch May 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@nihal467 nihal467 nihal467 approved these changes

@shivankacker shivankacker Awaiting requested review from shivankacker

Assignees
No one assigned
Labels
P1 High priority; urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sainak @nihal467 @vigneshhari @rithviknishad @khavinshankar @hrit2773