Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to handle filtering admitted but no bed assigned #1318

Merged
merged 23 commits into from
Sep 11, 2023

Conversation

yaswanthsaivendra
Copy link
Contributor

@yaswanthsaivendra yaswanthsaivendra commented May 27, 2023

Proposed Changes

  • updated the PatientFilterSet to handle the None option
  • made the necessary change in frontend and created an PR for the same.

Associated Issue

Architecture changes

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.05 ⚠️

Comparison is base (7d14e41) 56.71% compared to head (f201c9b) 56.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   56.71%   56.67%   -0.05%     
==========================================
  Files         199      199              
  Lines        9905     9914       +9     
  Branches     1654     1656       +2     
==========================================
+ Hits         5618     5619       +1     
- Misses       4232     4240       +8     
  Partials       55       55              
Impacted Files Coverage Δ
care/facility/api/viewsets/patient.py 50.90% <11.11%> (-1.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gigincg
Copy link
Member

gigincg commented May 29, 2023

cc: @yaswanthsaivendra

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
@yaswanthsaivendra
Copy link
Contributor Author

@vigneshhari @sainak @rithviknishad Added tests , Please Review!!

@nihal467
Copy link
Member

LGTM, @vigneshhari can you review it, don't merge it this week

@nihal467
Copy link
Member

nihal467 commented Sep 11, 2023

@vigneshhari can you review and merge it, we are planning to close it this week

@vigneshhari vigneshhari merged commit b0a7cc8 into ohcnetwork:master Sep 11, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants