[IMP] sales: update settings navigation for multi address #11442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @benderliz this PR is ready for a peer review, when you have a chance. Thank you! |
benderliz
approved these changes
Nov 22, 2024
|
Thank you @benderliz! Hi @ksc-odoo this PR is ready for a final review, when you have a chance. Thank you! |
ksc-odoo
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Hey @dikd-odoo -- just reviewed this PR. Nice job on this quick fix. Left an adjustment that requires your attention, to ensure the navigation is as accurate as possible. If you have any questions, don't hesitate to reach out. Once you implement the adjustment, feel free to tag this for Tech Review. Thanks! 👍
content/applications/sales/sales/send_quotations/different_addresses.rst
Outdated
Show resolved
Hide resolved
[FIX] Apply suggestions from KSC review Co-authored-by: ksc-odoo <[email protected]>
dikd-odoo
force-pushed
the
18.0-sales-customer-addresses-dikd
branch
from
f53472d
to
c9e5692
Compare
|
Hi @ksc-odoo thank you for the edits and review! Hello @samueljlieber this PR is ready for technical review, when you have a chance. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Sales app documentation on utilizing multiple customer addresses from [outdated] Sales app > Configuration > Settings to [updated] Accounting > Configuration > Settings.
Task: https://www.odoo.com/odoo/my-tasks/4293822