[IMP] Manufacturing: update MO costs #11422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @benderliz, This is ready for the first round of review. Thanks, |
benderliz
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
@hojo-odoo John, excellent work on this PR!!! I left a few relatively minor suggestions. The overall structure and writing of this doc is very easy to follow. Great job! :)
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
18.0-manufacturing-update-mo-costs-hojo
branch
from
f902d32
to
361fd40
Compare
|
Hey @ksc-odoo, This PR is ready for final review. Thanks, |
ksc-odoo
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
hey @hojo-odoo -- just finished Final Reviewing this PR. Nice job. Just a small collection of comments that require your attention. Once you address those, and implement the necessary changes, feel free to tag this for Tech Review. 👍
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/basic_setup/mo_costs.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
18.0-manufacturing-update-mo-costs-hojo
branch
from
361fd40
to
08b5b8c
Compare
|
Hey @samueljlieber and @jero-odoo, This PR is ready for tech review. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Manufacturing Order Costs doc to better explain the differences between the cost for a specific employee, and the employee cost set on a work center form.