Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle kaniko build failures #101

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Conversation

dsavchenko
Copy link
Member

No description provided.

@dsavchenko dsavchenko linked an issue Aug 18, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #101 (2887760) into master (05b5328) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   20.25%   20.06%   -0.19%     
==========================================
  Files          31       31              
  Lines        2632     2656      +24     
==========================================
  Hits          533      533              
- Misses       2099     2123      +24     
Files Changed Coverage Δ
nb2workflow/deploy.py 0.00% <0.00%> (ø)
setup.py 0.00% <ø> (ø)

@dsavchenko dsavchenko marked this pull request as ready for review August 21, 2023 14:40
nb2workflow/deploy.py Outdated Show resolved Hide resolved
Co-authored-by: Volodymyr <[email protected]>
@dsavchenko
Copy link
Member Author

Could you merge? I don't have permissions

@volodymyrss volodymyrss merged commit 6524011 into master Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handle kaniko build timeout and container build errors
3 participants