Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fits file input with filters (for Euclid) and styling (support for oda:label, oda:description and oda:group) #40

Merged
merged 24 commits into from
Aug 20, 2024

Conversation

burnout87
Copy link
Contributor

No description provided.

@burnout87 burnout87 changed the title adding fits file input with styling Fits file input with filters (for Euclid) and styling Jul 29, 2024
@volodymyrss
Copy link
Member

volodymyrss commented Aug 13, 2024

@dsavchenko suggests to have it generic, like in galaxy. maybe in the future

@burnout87 burnout87 changed the title Fits file input with filters (for Euclid) and styling Fits file input with filters (for Euclid) and styling (support for oda:label, oda:description and oda:group) Aug 13, 2024
@burnout87 burnout87 marked this pull request as ready for review August 19, 2024 12:28
Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't really have much to say, if it works it's good. Let's wait for @dsavchenko and also I suppose you checked with @motame that it's ok?

@burnout87
Copy link
Contributor Author

I have not really checked with @motame , I'll put him also as a reviewer...

@burnout87 burnout87 requested a review from motame August 19, 2024 15:08
@motame motame merged commit 2ee0275 into master Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in Euclid UI element, read catalog fits file to get list of possible fields
3 participants