Update date_of_day_before docstring #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the docstring was referring to an upper bound inclusive convention for date ranges. Since there is no such convention in the Kraken coding conventions, this can be confusing for the developers. This change updates the docstring to reflect the fact that it is a thing we usually do, but there's no written convention for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the docstring was referring to an upper bound inclusive convention for date ranges. Since there is no such convention in the Kraken coding conventions, this can be confusing for the developers.
This change updates the docstring to reflect the fact that it is a thing we usually do, but there's no written convention for it.