feat: add query cache #1520
Open
feat: add query cache #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shenglehust
reviewed
Aug 30, 2023
| @@ -1390,6 +1413,13 @@ class ObSQLSessionInfo: public common::ObVersionProvider, public ObBasicSessionI | |||
| bool is_send_control_info_ = false; // whether send control info to client | |||
| bool auto_flush_trace_ = false; | |||
| bool coninfo_set_by_sess_ = false; | |||
| // use for query cache | |||
| bool use_query_cache_ = false; | |||
There was a problem hiding this comment.
这些信息可以创建一个QueryCacheCtx结构, 然后放入放到ExecContext中, 不要放在session中
shenglehust
reviewed
Aug 30, 2023
src/sql/query_cache/ob_query_cache.h
Outdated
| int64_t row_cnt_; | ||
| common::ObArenaAllocator inner_alloc_; | ||
| common::ObSafeArenaAllocator alloc_; | ||
| DRWLock lock_; |
| @@ -1338,6 +1338,13 @@ int ObSelectResolver::resolve_query_options(const ParseNode *node) | |||
| LOG_USER_ERROR(OB_ERR_CANT_USE_OPTION_HERE, "SQL_CALC_FOUND_ROWS"); | |||
| } | |||
| } | |||
| LOG_INFO("ObSelectResolver resolve_query_options"); | |||
| private: | ||
| ObQueryCache() : instance_(nullptr), row_mem_size_(0), row_cnt_(0), alloc_(inner_alloc_) {} | ||
|
|
||
| private: |
| TO_STRING_KV(KP(query_cache_value_), K(handle_)); | ||
| }; | ||
|
|
||
| class ObQueryCache : public common::ObKVCache<ObQueryCacheKey, ObQueryCacheValue> |
| int ObQueryCache::flush() | ||
| { | ||
| int ret = OB_SUCCESS; | ||
| destroy(); |
There was a problem hiding this comment.
这个flush 实现太粗爆, 直接将query cache对象destroy然后init一个新的, 存在与实际请求并发问题, 可以看下kv cache使用下, flush相关实现;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
Solution Description
Add query cache to cache SQL and corresponding result sets, which can get better performance in a large number of repeated query scenarios，
Passed Regressions
Upgrade Compatibility
Other Information
Release Note