Add RFC: Separate context bar code into UI and plugins #61
+98
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norihiro
force-pushed
the
context-bar-in-plugins
branch
from
3e126ea
to
d14da66
Compare
norihiro
force-pushed
the
context-bar-in-plugins
branch
2 times, most recently
from
e45172d
to
312f858
Compare
norihiro
force-pushed
the
context-bar-in-plugins
branch
from
312f858
to
db44541
Compare
|
I like this approach! I thought of a similar concept (to the first variation of the two) a while back so was happy to see this RFC. Additionally, this doesn't handle what happens to things that are currently custom crafted, like media controls. Sources like the media source currently indicate that they can be media controlled, should those just not implement this new API? What should happen if they both implement this but also can be controlled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This RFC proposes to separate the implementation of the context bar into
UI/andplugins/.Motivation and Context
UI has the implementation of the context-bar for each source type.
As the result, property names are hard-coded in both UI and plugins.
In possible future modification, it might require to change both plugin and UI, which might lead a potential bug.
It is a good implementation to separate the plugin-specific implementation from the UI.
This will also enable 3rd party plugins to have their context bar.
Rendered RFC