Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-capture: Rename Screen Capture as Display Capture #10587

Merged
merged 1 commit into from May 4, 2024

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Apr 22, 2024

Description

Fix the naming

Motivation and Context

The source is wrongly named. Source: Warchamp7

How Has This Been Tested?

New wording is shown.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added UI/UX Anything to do with changes or additions to UI/UX elements. Linux Affects Linux labels Apr 22, 2024
@tytan652 tytan652 force-pushed the this_is_not_a_screen_capture branch 4 times, most recently from de1c217 to c453315 Compare April 23, 2024 09:50
@Warchamp7
Copy link
Member

Noting the thoughts down here:

When a source is specifically for capturing an entire physical display/monitor, we use Display Capture as the naming paradigm.

We want to reserve Screen Capture specifically for multi-purpose capture that can capture ex. An entire screen OR a window OR a specific region, etc. within the same unified source.

@Lain-B Lain-B merged commit 832ac4b into obsproject:master May 4, 2024
14 checks passed
@tytan652 tytan652 deleted the this_is_not_a_screen_capture branch May 4, 2024 23:16
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux Affects Linux UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants