Architecture: adding windows on ARM support #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WizardCM
reviewed
Jul 16, 2024
thirumalai-qcom
force-pushed
the
aarch64_support
branch
2 times, most recently
from
0693017
to
ac1075a
Compare
thirumalai-qcom
changed the title
thirumalai-qcom
force-pushed
the
aarch64_support
branch
from
ac1075a
to
285c5dc
Compare
thirumalai-qcom
force-pushed
the
aarch64_support
branch
from
285c5dc
to
ddcaa3f
Compare
Adjusted the frame retrieval method for ARM64 architecture. Separated frame retrieval logic for ARM64 using GetFrameByName and for other architectures using GetFrame. This ensures proper functioning across different architectures.
Updated the OnAcceleratedPaint method to handle ARM64 architecture specifically. This includes conditional compilation for _M_ARM64 to use CefAcceleratedPaintInfo and shared texture handles appropriately.
thirumalai-qcom
force-pushed
the
aarch64_support
branch
from
ddcaa3f
to
7022c48
Compare
|
This will need to be rebased now that #434 has been merged. |
Hi Ryan, I have reviewed the mainline, and it seems that the changes in this PR have already been merged through PR #434. Could you please let me know if there are any specific reasons or additional changes you would like to see in this PR that necessitate a rebase? |
|
If all changes in this PR are covered or superseded by #434, then this PR can simply be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the OBS-browser module to the latest CEF (Chromium Embedded Framework) library. This update necessitates changes to existing function declarations and signatures to align with the new library's specifications. Additionally, ARM architecture support has been introduced, with modifications guarded by ARM-specific macros to ensure compatibility without affecting the existing codebase.
Motivation and Context
The primary motivation for this change is to keep the OBS-browser module up-to-date with the latest CEF library with the new features. Additionally, expanding compatibility to include ARM-based systems allows a broader range of users to benefit from the OBS-browser functionalities.
How Has This Been Tested?
The changes have been tested by building OBS Studio on an ARM machine (X elite machine). All builds were successful, Basic functionality tests confirmed that the OBS Studio application with the modified obs-browser is functional.
Types of changes
Checklist: