REALLY don't allow browser docks to arbitrarily close OBS #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The previous solution only worked for code that ran after the page had finished loading. I was hoping that'd solve the problem for most users, which it didn't. But even if it did, we still don't want browser docks to be able to arbitrarily close the main OBS window.
How Has This Been Tested?
Implement a page that calls
window.close()
immediately.Types of changes
Checklist: