Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REALLY don't allow browser docks to arbitrarily close OBS #430

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

WizardCM
Copy link
Member

Description

Motivation and Context

The previous solution only worked for code that ran after the page had finished loading. I was hoping that'd solve the problem for most users, which it didn't. But even if it did, we still don't want browser docks to be able to arbitrarily close the main OBS window.

How Has This Been Tested?

Implement a page that calls window.close() immediately.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The previous solution only worked for code that ran *after* the page had
*finished* loading.
@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Dec 26, 2023
@RytoEX RytoEX self-assigned this Jan 10, 2024
@RytoEX
Copy link
Member

RytoEX commented Jan 10, 2024

Is there a test page I can use to test this, or do I need to create one myself?

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it seems to work.

@RytoEX RytoEX merged commit 7fa3822 into obsproject:master Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants