Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the keycloak image repository for docker-compose #2596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvanzuijlen
Copy link
Member

Description

The jboss/keycloak repository doesn't exist anymore. The keycloak/keycloak repository on Dockerhub doesn't have the v10 image, quay.io does and has recently been updated.

Motivation and Context

Found it because of the Renovate warning complaining it couldn't look up 1 of the dependencies

How Has This Been Tested?

Local docker pull to verify

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@kvanzuijlen kvanzuijlen requested a review from a team as a code owner April 7, 2024 08:42
@@ -43,7 +43,7 @@ services:

keycloak:
container_name: keycloak
image: jboss/keycloak:10.0.2
image: quay.io/keycloak/keycloak:10.0.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

Eventhough this is just a test file. We should update to the latest keycloak version which is 24.

For that we will need to update the keycloak realm and user file as well.

@kvanzuijlen do you know how to do it or should i add to this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no experience with keycloak, so it may be better if you did that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants