Support x-go-type-skip-optional-pointer in client query #1695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
We've tried to use x-go-type-skip-optional-pointer with optional slices in our code base. But generated client code became invalid. Original template makes dereference of pure slice.
I've added an extra check for this case, for query parameters. Other param locations may need the same check.
Note, that supporting optional not-nilable types (ex int) with x-go-type-skip-optional-pointer requires extra work. As
if params.{{.GoName}} != nil
check will not compile. But zero value semantic is not well defined in this case.