Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix auto unread thread traversal #3097

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Fix auto unread thread traversal #3097

wants to merge 4 commits into from

Conversation

koenpunt
Copy link
Contributor

@koenpunt koenpunt commented Nov 26, 2016 •
edited

My comment on #2825

I did some investigation, and found that this is happening because the message isn't available in the "unread" set after being read, for which in the thread list is accounted for by tracking recently read threads (RecentlyReadStore), but doesn't do this in the ThreadListStore.
I tried to fix this in #3097, but apparently the RecentlyReadStore isn't updated before there.

Nb. My fix is based on the source here: src/flux/models/unread-query-subscription.es6#L16-L27

@koenpunt koenpunt changed the title Fix auto unread thread traversal WIP: Fix auto unread thread traversal Nov 26, 2016
@koenpunt koenpunt force-pushed the fix-auto-unread-thread-traversal branch from 2100ef2 to ad4c87d Compare November 26, 2016 13:38
@jyboudreau jyboudreau mentioned this pull request Dec 14, 2016
Open
@jstejada jstejada force-pushed the master branch 2 times, most recently from ef74afe to 6d2c2b2 Compare April 18, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@koenpunt