Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with title >255 characters not showing up on EWS calendar #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aiirwiick
Copy link

Background

Fixed EWS calendar title length bug where the event wouldn't be created if a user submitted an event with a title >255 characters through Nylas API
https://app.clubhouse.io/nylas/story/18334/event-with-a-title-255-characters-accepted-on-nylas-but-failed-to-create-on-ews-calendar

Implementation

Changed 'subject' attribute to TextField class instead of CharField class in items.py

Tests

Tested local exchangelib by trying to create calendar events with titles >255 on test account

@shortcut-integration
Copy link

@ecederstrand
Copy link
Contributor

ecederstrand commented Jun 8, 2021

Hi @aiirwiick

I don't think this is a good solution because EWS actually only supports subjects up to 255 chars. You will find that if you create items with a longer subject, EWS will truncate the subject at 255 chars, adding a ... at the end if it was truncated.

I think it's better to handle excessive subject lengths in the part of your own code that creates the CalendarItem.

@pengfeiye pengfeiye removed their request for review October 21, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants