Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not strip away special characters from project names #121

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

utarwyn
Copy link
Member

@utarwyn utarwyn commented May 20, 2024

This PR modifies the project names used in the generators to improve the Go module and package names in the generated files.

Resolves #118

@utarwyn utarwyn added the type: bug Something isn't working label May 20, 2024
@utarwyn utarwyn added this to the 3.1.x milestone May 20, 2024
@utarwyn utarwyn self-assigned this May 20, 2024
@utarwyn utarwyn requested a review from phillipCouto May 20, 2024 20:28
@phillipCouto
Copy link
Contributor

Thank you for the fix. I will review it this evening 😊.

Copy link

sonarcloud bot commented May 26, 2024

@utarwyn utarwyn requested a review from phillipCouto May 26, 2024 15:38
Copy link
Contributor

@phillipCouto phillipCouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @utarwyn, thank you for the fix 😄.

@utarwyn
Copy link
Member Author

utarwyn commented Jun 1, 2024

Thank you for the feedback 💯

@utarwyn utarwyn merged commit 7d03eda into main Jun 1, 2024
5 checks passed
@utarwyn utarwyn deleted the issue-118-project-names branch June 1, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generators strip away '/' and '-' from project names when creating go.mod
2 participants