Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3091

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update README.md #3091

wants to merge 1 commit into from

Conversation

tspatek
Copy link

@tspatek tspatek commented Apr 19, 2023

Install & Update Script Section

  • Line 96: Added If you use macOS, you must install Xcode and agree to the Xcode License before you install nvm. under heading.
  • Line 106: Added If you don't have a profile file in your home dir, you'll need to add the appropriate one before you run the script. to the end of the paragraph.

Install & Update Script Section

 - Line 96: Added **If you use macOS, you must install Xcode and agree to the Xcode License before you install nvm.**under heading.
 - Line 106: Added **If you don't have a profile file in your home dir, you'll need to add the appropriate one before you run the script.** to the end of the paragraph.
@@ -93,6 +93,8 @@ nvm is a version manager for [node.js](https://nodejs.org/en/), designed to be i

### Install & Update Script

**If you use macOS, you must install Xcode and agree to the Xcode License before you install nvm.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't strictly true - it's that you need the things the xcode command line tools install, but you could have installed them other ways. also the license part doesn't seem useful to document here, xcode itself can handle that.

@Xcalibur53 Xcalibur53 linked an issue Apr 21, 2023 that may be closed by this pull request
@ljharb ljharb marked this pull request as draft May 17, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spam]
2 participants