feat(layout_config) Adds the option to configure additional lines of padding around the anchor of the layout (#2851) #3035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new option to layout_config called anchor_padding. When set to a positive integer, it adds
additional lines of padding around the anchor of a layout.
Fixes #2851
Type of change
How Has This Been Tested?
This results in the following layout:
The result we care about is the ten lines of additional space between the bottom of the screen and the start of the layout.
This results in the following layout:
The result we care about is the two lines of additional space between the top of the screen and the start of the layout.
Configuration:
OS: Manjaro Linux x86_64
Host: Laptop (12th Gen Intel Core) A4
Kernel: 6.1.80-1-MANJARO
Checklist:
I am not quite sure what this last point is about, so I left it open.
Open question:
I have not provided additional tests. I have changed the existing tests to mimic the previous behavior by setting anchorpadding to 1 where applicable. Since this is my first contribution, I am unsure about this. Additional feedback is appreciated.