Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filesystem): remove redundant exclusion breaking filter for find (#1459) #1564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obukhovaa
Copy link

Not sure what was the purpose of that exclusion, but it was causing issues when find command is used within filter logic.

if not ignore.dotfiles then
  append("-not", "-path", "*/.*")
end

You would expect that when ignore-dotfiles is false you don't want to exclude dot files and directories. In fact it was not just excluding dot files, but all the other valid options if current path contains any . directories. For example for me the resulting command was

find  "/Users/nouwa/.config/nvim" -not -path '*/.*' -iname "*lua*"

and because my path has .config -- all files were excluded, producing empty search result.

Once this section removed, eveyrhing works as expected with both ignore.dotfiles = true and false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant