fix(filesystem): remove redundant exclusion breaking filter for find (#1459) #1564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what was the purpose of that exclusion, but it was causing issues when
find
command is used withinfilter
logic.You would expect that when
ignore-dotfiles
isfalse
you don't want to exclude dot files and directories. In fact it was not just excluding dot files, but all the other valid options if currentpath
contains any.
directories. For example for me the resulting command wasand because my path has
.config
-- all files were excluded, producing empty search result.Once this section removed, eveyrhing works as expected with both
ignore.dotfiles = true
andfalse
.