fix: edge case where buffer is added two times to buffers component #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The total length check for the buffers component first checks if it has enough space to add a before before, then adds it and then checks it for buffers after the current one. If that second check fails the before buffer is added a second time to the buffer component, this time as an ellipsis which can lead to confusing behavior and unwanted visual artifacts. This commit fixes this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total length check for the buffers component first checks if it has enough space to add a before buffer, then adds it and then checks it for buffers after the current one. If that second check fails the before buffer is added a second time to the buffer component, this time as an ellipsis which can lead to confusing behavior and unwanted visual artifacts. This commit fixes this problem.
Here is a screenshot to better illustrate the issue. Note the missing bar after the ellipsis:
Before:
After:
