feat(RadioGroup): Add selected binding #1587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ | |||
| @change="onUpdate(option.value)" | |||
| > | |||
| <template #label> | |||
| <slot name="label" v-bind="{ option }" /> | |||
| <slot name="label" v-bind="{ option, selected: option.selected }" /> | |||
There was a problem hiding this comment.
Why do you need to inject the selected in every option? You could just have it globally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #1563
❓ Type of change
📚 Description
The idea is to create a binding name 'selected' that returns a boolean if a radio is selected or not.
So I've created a new function named: guessOptionSelected(option: any) and passed it as a value of the key "selected" in the return of normalizeOptions function.
Then I've created a bind 'selected: option.selected' in the slot.
Code example:
Video example:
https://github.com/nuxt/ui/assets/105924355/e6a07932-a7d7-4fbf-bcba-c415fff1beb8
📝 Checklist