fix(nuxt): normalise encoded trailing slashes before redirecting #26994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
manniL
reviewed
Apr 30, 2024
Comment on lines
+281
to
+284
| const ENCODED_TRAILING_SLASH_RE = /%2F$/ | ||
| function isSamePath (initialURL: string, path: string) { | ||
| return withoutTrailingSlash(decode(initialURL).replace(ENCODED_TRAILING_SLASH_RE, '/')) === withoutTrailingSlash(decode(path).replace(ENCODED_TRAILING_SLASH_RE, '/')) | ||
| } |
There was a problem hiding this comment.
Is this something we should consider fixing/handling in ufo too?
There was a problem hiding this comment.
I thought he might not want to make this change, but what do you think @pi0?
There was a problem hiding this comment.
For path comparation utils? i guess makes sense
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #26882
📚 Description
This manually normalises encoded trailing slashes before comparing the paths to see if a redirect is required.