perf(nuxt): mark define functions as side-effect free at source #21434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Rollup now supports marking a function as sied-effect free:
#__NO_SIDE_EFFECTS__
annotation for function declaration rollup/rollup#5024This PR marks the following functions as side-effect free
createClientOnly
defineNuxtComponent
defineNuxtLink
definePayloadPlugin
defineNuxtPlugin
useNuxtApp
useRuntimeConfig
As listed here:
nuxt/packages/vite/src/client.ts
Lines 80 to 83 in 6045beb
A PR was also sent to Vue core to mark
defineComponent
anddefineAsyncComponent
defineComponent
as side-effects-free vuejs/core#8512Once this convention gets more widely adopted, we may be able to remove the
pureAnnotationsPlugin
later.