Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support variable axis #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

qwerzl
Copy link
Collaborator

@qwerzl qwerzl commented Apr 26, 2024

This PR adds support for variable font axis. It's quite sad that AFAIK only Google provides this level of configuration.

@qwerzl qwerzl requested a review from danielroe April 26, 2024 14:03
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 26, 2024
@dosubot dosubot bot added the enhancement New feature or request label Apr 26, 2024
@qwerzl qwerzl marked this pull request as draft April 27, 2024 22:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 64.50%. Comparing base (ed5f704) to head (725d358).

Files Patch % Lines
playground/pages/providers/google.vue 0.00% 11 Missing ⚠️
src/module.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   63.70%   64.50%   +0.79%     
==========================================
  Files          41       41              
  Lines        2717     2789      +72     
  Branches      397      426      +29     
==========================================
+ Hits         1731     1799      +68     
- Misses        960      966       +6     
+ Partials       26       24       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerzl qwerzl marked this pull request as ready for review April 28, 2024 00:55
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 28, 2024
@qwerzl
Copy link
Collaborator Author

qwerzl commented Apr 28, 2024

Hi @danielroe, the type issues are fixed and I've added tests for Recursive. Sorry I didn't see the failed checks yesterday so it took some time.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than creating a new property (variableAxis) I think we ought to try to use font-variation-settings/variationSettings which could take a string or an object of dimension/value.

We could then use this to render both the font-face and also detect the required variations from CSS directly rather than require it to be configured.

@qwerzl
Copy link
Collaborator Author

qwerzl commented May 3, 2024

@danielroe I've also thought about this, but I'm not sure whether font-variation-settings allows a range of values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants