Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port upstream navigateTo composables #1102

Closed
wants to merge 10 commits into from
Closed

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Feb 8, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The bug is resolved by porting the upstream implementation.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@AndreyYolkin
Copy link
Contributor

AndreyYolkin commented Apr 8, 2024

Hi! woyld you mind if I take your PR as a base, backport open option and open new PR?

@wattanx
Copy link
Collaborator Author

wattanx commented Apr 8, 2024

@AndreyYolkin
I think it is a good idea to base this PR branch on this PR branch!
(Including open backports in this PR should be avoided)

@wattanx wattanx mentioned this pull request May 3, 2024
7 tasks
@wattanx
Copy link
Collaborator Author

wattanx commented May 19, 2024

I have merged #1197 and will close this PR

@wattanx wattanx closed this May 19, 2024
@danielroe danielroe deleted the fix/upstream-navigate-to branch May 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants