chore(useStrapi): add optional query params to create / update in v5
#426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nuxt-strapi-module pending review.Visit the deploys page to approve it
|
LeonGatt
reviewed
Sep 27, 2024
| * @returns Promise<T> | ||
| */ | ||
| const update = <T>(contentType: string, documentId: string | Partial<T>, data?: Partial<T>): Promise<Strapi5ResponseSingle<T>> => { | ||
| const update = <T>(contentType: string, documentId: string | Partial<T>, data?: Partial<T>, params: Strapi5RequestParams = {}): Promise<Strapi5ResponseSingle<T>> => { |
There was a problem hiding this comment.
U probably wanted to assign the params to the client. In that case u'd fix pipelines.
return client(path, { method: 'PUT', body: { data }, params })
There was a problem hiding this comment.
Ty. Idk how i missed that lol
benjamincanac
changed the title
create / update
benjamincanac
approved these changes
Sep 30, 2024
benjamincanac
changed the title
create / updatecreate / update in v5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives the developer the ability to send params while doing a create/update for Strapiv5.
The
Strapi5RequestParamsoption was added to both functions.I may be wrong about this so feel free to discard this PR if this is not a thing in v5(I am sure I read it somewhere)
Types of changes
Description
This change gives the developer the ability to send params while doing a create/update for Strapiv5.
I think Strapi allows you to do stuff like populate on create
Checklist: