ignore this pull request; see #2914 instead #2906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: disable caching for dynamic locale messages * docs: add warning about current cache behaviour
* feat: layer vue i18n config merging * test: update snapshot * fix: layer vuei18n configurations merge order * test: disable jit compilation for vuei18n layer test * docs: describe VueI18n option merging on layers page
* feat: locale message file cache configuration * test: fix types and failing errors * fix: nuxtInternalOptions `__normalizedLocales` * refactor: simplify types * refactor: remove duplicate utility function * docs: add caching section to lazy-load translations guide * test: add test to assert cache configuration is used
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-modules#2368) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ules#2371) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…: true. (nuxt-modules#2363) Fixed protocol because URL(window.localtion.origin).protocol contains already ":". Si we don't need to add them again when we return the URL.
…dules#2383) * Fixed a bug where the correct locale.code could not be obtained when differentDomains: true and locale.domain is set with a protocol header. * add spec issues 2374 * fix getLocaleDomain * Fixed a bug where the correct locale.code could not be obtained when differentDomains: true and locale.domain is set with a protocol header. * fix: cannot resolve message for jit compilation (nuxt-modules#2387) * fix getLocaleDomain --------- Co-authored-by: kazuya kawaguchi <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update `vue-i18n-routing` to `^1.0.2` * test: add test to confirm query parameters are retained
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…es#2399) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…s#2405) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…modules#2402) * fix: disable typescript checking for generated i18n.options.mjs * test: update snapshots
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…dules#2417) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…s#2882) * fix: locales provided via `installModule` being ignored * fix: use `locales` and `vueI18n` passed by `installModule` * test: add `installModule` options tests * docs: add `installModule` documentation
…x'` (nuxt-modules#2897) * fix: locale head not updating on locale change using `strategy: 'no_prefix'` * test: add locale head tests for `'no_prefix'` strategy * test: fix flakiness by waiting for title change
…lity of default locales per domain
pascalvanstiphout
approved these changes
Apr 12, 2024
…l not be created or will be removed.
e-kravtsov
reviewed
Apr 16, 2024
| let host: string | undefined | ||
| if (import.meta.client) { | ||
| host = window.location.host | ||
| } else if (import.meta.server) { | ||
| const header = useRequestHeaders(['x-forwarded-host', 'host']) | ||
|
|
||
| let detectedHost: string | undefined | ||
| if ('x-forwarded-host' in header) { | ||
| if (nuxtApp?.ssrContext?.event?.context.storeHost) { |
There was a problem hiding this comment.
this will fire only if you add a server plugin like
export default defineNitroPlugin((nitro) => {
nitro.hooks.hook('request', (event) => {
event.context.storeHost = 'host-you-want-to-use.com' // or get the host from event manually;
});
});
It gives more control and easier for local development, if you don't want to use headers, or want to use your own header for any reason
Maybe we should add this to the docs
There was a problem hiding this comment.
Where in the docs would be a good place to add this?
There was a problem hiding this comment.
DarthGigi
force-pushed
the
multilocales-multidomain
branch
from
d76bb16
to
a523661
Compare
|
I think I screwed something up 😬... |
|
Please check out the new pull request: #2914 |
DarthGigi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out #2914 instead.