Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate legacy dynamic route params fully #2801

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is actually a breaking change, but we have marked this functionality a deprecated before stable v8 release, so I don't think it should be marked as breaking? πŸ€” I'm not sure..

The deprecation of using nuxtI18n with definePageMeta was a bit soft, as we kept using the same key internally for setI18nParams I can imagine there may have been users ignoring the warning. So I added a similar warning that should only be logged in a development environment and changed the nuxtI18n key to nuxtI18nInternal, this will break the functionality for projects using the deprecated functionality and better communicate that this is an internal key. At some point we may or may not move away from using the meta key on routes.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

nuxt-studio bot commented Feb 16, 2024

βœ… Live Preview ready!

Name Edit Preview Latest Commit
i18n Edit on Studio β†—οΈŽ View Live Preview 3ea37e1

@kazupon
Copy link
Collaborator

kazupon commented Feb 17, 2024

Thank you!

I had planned to drop features in v8.1 that I had marked as deprecated prior to the v8.0 release.
However, nuxt i18n versioning is in semver, and according to semver policy that is equivalent to a major change.
And also, the recent OSS semver for automatic tracking tools like renovate and dependbot, as well as release tools.

So I believe that if we drop deprecation, we should release as v9.

There may be other deprecations in nuxt i18n.
I think we should pickup all of them once and drop them and release v9.

@BobbieGoede BobbieGoede added the v9 label Feb 19, 2024
@BobbieGoede
Copy link
Collaborator Author

However, nuxt i18n versioning is in semver, and according to semver policy that is equivalent to a major change.

There may be other deprecations in nuxt i18n.
I think we should pickup all of them once and drop them and release v9.

I agree, I'll label it v9 and set it to draft. It's good to be careful with breaking changes, I think with some planning it can be combined with some other changes.

Maybe I'll open an issue/discussion for v9 in the coming days to track which issues/changes could be included so users can give feedback or suggest changes.

@BobbieGoede BobbieGoede marked this pull request as draft February 19, 2024 16:20
@kazupon
Copy link
Collaborator

kazupon commented Feb 20, 2024

Maybe I'll open an issue/discussion for v9 in the coming days to track which issues/changes could be included so users can give feedback or suggest changes.

Good idea! πŸ‘
Let's open the issue/discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants